Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat) Add XFCC authenticated scaling engine endpoint #3320

Merged
merged 7 commits into from
Nov 27, 2024

Conversation

bonzofenix
Copy link
Contributor

@bonzofenix bonzofenix commented Nov 12, 2024

This pull request adds a new xfcc unified endpoint to the scaling engine that will be consumed by the API component once it is deployed as a Cloud Foundry application.

includes several changes to the deploy-autoscaler.sh script, configuration files, and tests related to the autoscaler deployment and CF server configurations. The most important changes include refactoring the deploy-autoscaler.sh script for better readability and maintainability, adding new CF server configurations, and updating tests to reflect these changes.

Script Refactoring:

  • Refactored the deploy-autoscaler.sh. [1] [2]

Configuration Updates:

  • Added new properties for CF server configuration in jobs/scalingengine/spec.
  • Updated the scalingengine.yml.erb template to include new CF server properties.
  • Modified use-cf-services.yml to add space and org GUIDs to the scaling engine.

Test Updates:

  • Updated tests in scalingengine_spec.rb to include checks for the new CF server configurations.
  • Renamed GetServer to CreateServer in broker_server.go and updated corresponding tests. [1] [2] [3]
  • Refactored tests in api_test.go. [1] [2] [3] [4]

@bonzofenix bonzofenix force-pushed the add-cf-endpoint-to-scaling-engine branch 2 times, most recently from 298d79a to a1d0bd6 Compare November 13, 2024 13:07
@bonzofenix bonzofenix added the allow-acceptance-tests This label needs to be added to enable the acceptance tests to run. label Nov 13, 2024
@bonzofenix bonzofenix force-pushed the add-cf-endpoint-to-scaling-engine branch 14 times, most recently from c74ad60 to 2ef9a85 Compare November 13, 2024 22:49
@bonzofenix bonzofenix changed the title Add cf endpoint to scaling engine (feat) Add XFCC authenticated endpoint to scaling engine service Nov 14, 2024
@bonzofenix bonzofenix force-pushed the add-cf-endpoint-to-scaling-engine branch 2 times, most recently from 90fe189 to 98442f6 Compare November 14, 2024 10:16
@bonzofenix bonzofenix enabled auto-merge (squash) November 14, 2024 10:17
@bonzofenix bonzofenix changed the title (feat) Add XFCC authenticated endpoint to scaling engine service (feat) Add XFCC authenticated endpoint for scaling engine service Nov 14, 2024
@bonzofenix bonzofenix changed the title (feat) Add XFCC authenticated endpoint for scaling engine service (feat) Add XFCC authenticated scaling engine endpoint Nov 14, 2024
@bonzofenix bonzofenix disabled auto-merge November 14, 2024 16:36
@bonzofenix bonzofenix force-pushed the add-cf-endpoint-to-scaling-engine branch 2 times, most recently from 0bdb2c9 to a427b67 Compare November 18, 2024 12:13
jobs/scalingengine/spec Outdated Show resolved Hide resolved
jobs/scalingengine/spec Outdated Show resolved Hide resolved
src/autoscaler/api/cmd/api/api_test.go Outdated Show resolved Hide resolved
src/autoscaler/api/publicapiserver/public_api_server.go Outdated Show resolved Hide resolved
src/autoscaler/routes/routes.go Show resolved Hide resolved
@bonzofenix bonzofenix force-pushed the add-cf-endpoint-to-scaling-engine branch 2 times, most recently from 29d66c0 to 9dcb3fd Compare November 21, 2024 12:30
@bonzofenix bonzofenix requested a review from silvestre November 21, 2024 12:30
@bonzofenix bonzofenix force-pushed the add-cf-endpoint-to-scaling-engine branch 2 times, most recently from 532722b to 1875d2e Compare November 25, 2024 14:48
@bonzofenix bonzofenix force-pushed the add-cf-endpoint-to-scaling-engine branch from 1875d2e to ca3f8c5 Compare November 27, 2024 12:36
@bonzofenix bonzofenix enabled auto-merge (squash) November 27, 2024 13:05
@bonzofenix bonzofenix disabled auto-merge November 27, 2024 13:57
@bonzofenix bonzofenix merged commit de4bb15 into main Nov 27, 2024
27 checks passed
@bonzofenix bonzofenix deleted the add-cf-endpoint-to-scaling-engine branch November 27, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
allow-acceptance-tests This label needs to be added to enable the acceptance tests to run. enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants